Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GPC indication on fides-js overlay #3673

Merged
merged 13 commits into from
Jun 28, 2023
Merged

GPC indication on fides-js overlay #3673

merged 13 commits into from
Jun 28, 2023

Conversation

allisonking
Copy link
Contributor

@allisonking allisonking commented Jun 26, 2023 •
edited
Loading

Closes https://github.com/ethyca/fidesplus/issues/958

Description Of Changes

Adds GPC indicators to both the modal and the banner

Description Screenshot
Banner image
Toggle when GPC is applied image
If you opt into the opted-out toggle image

Code Changes

  • Add GpcBanner and GpcBadge as components
  • Move GpcStatus type and getGpcStatusFromNotice from privacy-center to fides-js so that fides-js can use it too
  • Render indicators on modal
  • Fix bug in automaticallyApplyGPCPreferences where the cookie consent would be missing keys of notices that were notice only, or already had a preference
  • Render indicator on banner
  • Cypress tests

Steps to Confirm

  • turbo dev in privacy center
  • Visit http://localhost:3000/fides-js-components-demo.html?globalPrivacyControl=true (note the flag that sets the gpc signal!)
  • You should see the banner with the indicator
  • Open the modal and you should see gpc applied in the first notice, but not the notice-only notice
  • Opt into the first notice
  • It should now say gpc overridden
  • Edit fides-js-components-demo.html so that the first notice has_gpc_flag=false
  • There should be no gpc indicator in the modal, but there will still be info messages saying gpc was detected

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Update CHANGELOG.md

@cypress
Copy link

cypress bot commented Jun 27, 2023 •
edited
Loading

Passing run #2950 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge ab01559 into 0337c66...
Project: fides Commit: 748abfd00c ℹ️
Status: Passed Duration: 00:43 💡
Started: Jun 28, 2023 5:27 PM Ended: Jun 28, 2023 5:27 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@allisonking allisonking marked this pull request as ready for review June 27, 2023 17:49
@allisonking allisonking force-pushed the aking/fidesplus-958/gpc-overlay branch from 1374143 to 47bcdb7 Compare June 27, 2023 17:52
eastandwestwind
eastandwestwind approved these changes Jun 27, 2023
View reviewed changes
Copy link
Contributor

@eastandwestwind eastandwestwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great @allisonking ! Especially, good catch on that bug 🐛 , just 1 request non-blocking, so I'll go ahead and approve.

clients/fides-js/src/lib/consent-types.ts Show resolved Hide resolved
clients/fides-js/src/lib/consent-value.ts Show resolved Hide resolved
clients/fides-js/src/fides.ts Show resolved Hide resolved
@allisonking allisonking merged commit dd7ebfa into main Jun 28, 2023
@allisonking allisonking deleted the aking/fidesplus-958/gpc-overlay branch June 28, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eastandwestwind eastandwestwind eastandwestwind approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@allisonking @eastandwestwind